burn(bug): Fix unused retSlot variable in LIR lowering#44
Draft
burn(bug): Fix unused retSlot variable in LIR lowering#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
01KNHZFNWBVC163XXGNY9R14TPDescription
In src/lir/lower.ts around lines 638-642, the variable
retSlotis declared but never used — thereturn_valueinstruction is emitted withsrcSlotdirectly instead. Investigate whetherretSlotshould be used (i.e., the instruction should copy srcSlot into the$retscoreboard slot explicitly) or whether the variable is a dead refactoring artifact and should be removed. Read the surrounding context and the emit stage handling ofreturn_valueinstructions to determine the correct fix, then apply it.Changes
Generated by burn-harness